implement selecting and highlighting function for field list and log #56
Open
stmoon wants to merge 1 commit intoDrTon:masterfrom
stmoon:select_item
Open
implement selecting and highlighting function for field list and log #56stmoon wants to merge 1 commit intoDrTon:masterfrom stmoon:select_item
stmoon wants to merge 1 commit intoDrTon:masterfrom
stmoon:select_item
Conversation
…nfo by pressing a first key.
Collaborator
|
Can one of the admins verify this patch? |
Owner
|
I like the idea, thanks and sorry for the long reply! But can you do this like separate helper, without duplicating the code? Also would be great if it can look not only first letter but also others if user prints fast enough (Mac OS style), so if delay from previous letter was < 1second accept pressed key as the second letter etc. That would be even better, if too complicated I can merge as is after duplicated code fix. |
Contributor
Author
|
Hi Anton. It's been a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement selecting and highlighting function for field list and log info by pressing a first key.